Install Abseil failure signal handler in distributor/proton daemons #30873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@toregge and @baldersheim please review.
This will attempt to dump a stack trace for the offending thread to
stderr
, which should greatly improve crash visibility and debug-ability for everyone running Vespa on systems with core dumps disabled.Signal handler chaining is explicitly enabled to allow sanitizer handlers to be called as expected.
Note that we install our own signal handlers after the Abseil handlers to avoid noisy stack dumping on
SIGTERM
. It is considered a fatal signal by the failure handler, but the config sentinel uses it as a friendly "please shutdown now, or else 😘" nudge in the common case.Example log output when doing a manual
kill -SEGV
of asearchnode
process that is also TSan-instrumented:Prior to this, all we'd get (if no core dumps are enabled) is the sound of silence and an exit code log message from the config sentinel.
This mostly resolves issue #29928, but does not currently apply to all C++ processes.