Fix parsing of array query properties in JSON payload #8697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were translated to request properties by calling asString on the payload, which returns an empty value for arrays. toString returns the correct value. This also improves error messages for Slime JSON parsing of queries, and in general.
henrhoi
reviewed
Mar 7, 2019
| @@ -577,14 +566,14 @@ public void createRequestMapping(Inspector inspector, Map<String, String> map, S | |||
| map.put(qualifiedKey , value.asString()); | |||
| break; | |||
| case ARRAY: | |||
| map.put(qualifiedKey, value.asString()); | |||
| map.put(qualifiedKey, value.toString()); // XXX: Causes parsing the JSON twice (Query.setPropertiesFromRequestMap) | |||
There was a problem hiding this comment.
👍 .
Weird that I did not notice this bug while testing... 😅
In any case, it is good that it gets fixed now.
henrhoi
suggested changes
Mar 7, 2019
Co-Authored-By: bratseth <bratseth@oath.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were translated to request properties by calling
asString on the payload, which returns an empty value for arrays.
toString returns the correct value.
This also improves error messages for Slime JSON parsing
of queries, and in general.
@arnej27959 og @henrhoi please review