Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Zc4/Zc5 postings with "cheap" features. #9317

Merged
merged 1 commit into from May 8, 2019

Conversation

toregge
Copy link
Member

@toregge toregge commented May 8, 2019

@geirst : please review

@toregge toregge requested a review from geirst May 8, 2019 10:44
Copy link
Member

@geirst geirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -10,7 +10,9 @@ namespace search::diskindex {
* Class used to read posting lists of type "Zc.4" and "Zc.5" (dynamic k).
*
* Common words have docid deltas and skip info separate from
* features.
* features. If "cheap" features are enabled then they are interleaved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also state what "cheap" features are.

@@ -12,7 +12,9 @@ namespace search::diskindex {
* Class used to write posting lists of type "Zc.4" and "Zc.5" (dynamic k).
*
* Common words have docid deltas and skip info separate from
* features.
* features. If "cheap" features are enabled then they are interleaved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also state what "cheap" features are.

@geirst geirst changed the title Extend Zc4/Zc5 postings with "cheap" features Extend Zc4/Zc5 postings with "cheap" features. May 8, 2019
@geirst geirst merged commit f69f960 into master May 8, 2019
@geirst geirst deleted the toregge/extend-zc4-postings-with-cheap-features branch May 8, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants