Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag for additional dynamic provisioning flavors #9353

Merged
merged 1 commit into from
May 10, 2019
Merged

Add flag for additional dynamic provisioning flavors #9353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 7 additions & 4 deletions flags/src/main/java/com/yahoo/vespa/flags/Flags.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@

import com.yahoo.vespa.defaults.Defaults;

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Optional;
import java.util.TreeMap;
Expand Down Expand Up @@ -66,7 +64,7 @@ public class Flags {
HOSTNAME);

public static final UnboundListFlag<String> DISABLED_HOST_ADMIN_TASKS = defineListFlag(
"disabled-host-admin-tasks", Collections.emptyList(),
"disabled-host-admin-tasks", List.of(),
"List of host-admin task names (as they appear in the log, e.g. root>main>UpgradeTask) that should be skipped",
"Takes effect on next host admin tick",
HOSTNAME, NODE_TYPE);
Expand Down Expand Up @@ -119,6 +117,11 @@ public class Flags {
"Takes effect on next deployment",
APPLICATION_ID);

public static final UnboundListFlag<String> DYNAMIC_PROVISIONING_FLAVORS = defineListFlag(
"dynamic-provisioning-flavors", List.of(),
"List of additional Vespa flavor names that can be used for dynamic provisioning",
"Takes effect on next provisioning");

public static final UnboundBooleanFlag ENABLE_DISK_WRITE_TEST = defineFeatureFlag(
"enable-disk-write-test", false,
"Regularly issue a small write to disk and fail the host if it is not successful",
Expand Down Expand Up @@ -237,7 +240,7 @@ private interface TypedUnboundFlagFactory<T, U extends UnboundFlag<?, ?, ?>> {
}

public static List<FlagDefinition> getAllFlags() {
return new ArrayList<>(flags.values());
return List.copyOf(flags.values());
}

public static Optional<FlagDefinition> getFlag(FlagId flagId) {
Expand Down