New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tagging of TermFieldMatchData #9548
Conversation
needed by feature executors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -112,6 +114,20 @@ HandleRecorder::add(TermFieldHandle handle, | |||
} | |||
} | |||
|
|||
void | |||
HandleRecorder::tag_match_data(MatchData &match_data) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: "{" should be on the next line.
@@ -112,6 +114,20 @@ HandleRecorder::add(TermFieldHandle handle, | |||
} | |||
} | |||
|
|||
void | |||
HandleRecorder::tag_match_data(MatchData &match_data) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For upcoming PR please add unit test for this in handle_recorder_test.cpp.
@@ -19,6 +20,7 @@ TermFieldMatchData::TermFieldMatchData() : | |||
TermFieldMatchData::TermFieldMatchData(const TermFieldMatchData & rhs) : | |||
_docId(rhs._docId), | |||
_fieldId(rhs._fieldId), | |||
_flags(UNPACK_ALL_FEATURES_MASK), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should copy flags from rhs
@geirst : please review
@havardpe : FYI