Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node-Admin: cfg client exceptions #9813

Merged
merged 6 commits into from Jun 16, 2019
Merged

Node-Admin: cfg client exceptions #9813

merged 6 commits into from Jun 16, 2019

Conversation

freva
Copy link
Member

@freva freva commented Jun 14, 2019

Makes the config server client throw HttpException, which is now instance of ConvergenceException for known and understood errors, like connection refused, timed out, etc.
NodeRepositoryException and OrchestratorException are now also instance of ConvergenceException.

@freva freva requested a review from hakonhall June 14, 2019 20:51
@freva freva merged commit c506af9 into master Jun 16, 2019
@freva freva deleted the freva/cfg-client-exception branch June 16, 2019 09:59
@freva freva mentioned this pull request Jun 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakonhall hakonhall hakonhall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freva @hakonhall