Get available limit from cgroups if set #9879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakonhall
reviewed
Jun 24, 2019
| @@ -71,6 +71,11 @@ configure_memory() { | |||
| available="$VESPA_TOTAL_MEMORY_MB" | |||
| else | |||
| available=`free -m | grep Mem | tr -s ' ' | cut -f2 -d' '` | |||
| if [ -x "$(command -v cgget)" ]; then | |||
There was a problem hiding this comment.
This doesn't work well unless cgget exists and is a program:
$ command -v foobar
$ command -v ls
alias ls='ls -G'
Looks like hash is ideal for this case:
if hash &>/dev/null; then
hakonhall
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns 2^63 if uncapped.
After we get rid of
VESPA_TOTAL_MEMORY_MB, I think we can change memory in container by just changing cgroup limit and restarting Vespa.