Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not reading from local config on L4 #24

Closed
greggilbert opened this issue Mar 19, 2013 · 4 comments
Closed

Not reading from local config on L4 #24

greggilbert opened this issue Mar 19, 2013 · 4 comments

Comments

@greggilbert
Copy link

Following up on #23. The result from that bug is that you have to edit the config in vendor/vespakoen/menu/src/config/config.php. Not a great idea when you're trying to commit your changes.

In Laravel you can run php artisan config:publish vespakoen/menu and have it copy the config to your local. You can then override the config with your local stuff. I've done this, but it doesn't seem to be using that local config.

@lancepioch
Copy link

I have this same problem. I did manage to overcome it by simply using: Menu::setOption('max_depth', 3);

@vespakoen
Copy link
Owner

Can someone try to change this line: https://github.com/Vespakoen/laravel-menu/blob/master/src/Menu/Menu.php#L191

to:

        return new Repository($fileLoader, 'menu::config');

And let me know if the published config overrides work then?

@Patapoof
Copy link

Nope, I tried this one, but it doesn't work. My local config (created via Artisan like greggilbert in the first post) specifies "ol" as the item list's element but it's still an ul in the rendered page, even after a cache:clear.

@vespakoen
Copy link
Owner

Fixed by pull request #50

Thanks nostalgie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants