-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not reading from local config on L4 #24
Comments
I have this same problem. I did manage to overcome it by simply using: |
Can someone try to change this line: https://github.com/Vespakoen/laravel-menu/blob/master/src/Menu/Menu.php#L191 to: return new Repository($fileLoader, 'menu::config'); And let me know if the published config overrides work then? |
Nope, I tried this one, but it doesn't work. My local config (created via Artisan like greggilbert in the first post) specifies "ol" as the item list's element but it's still an ul in the rendered page, even after a cache:clear. |
Fixed by pull request #50 Thanks nostalgie! |
Following up on #23. The result from that bug is that you have to edit the config in vendor/vespakoen/menu/src/config/config.php. Not a great idea when you're trying to commit your changes.
In Laravel you can run
php artisan config:publish vespakoen/menu
and have it copy the config to your local. You can then override the config with your local stuff. I've done this, but it doesn't seem to be using that local config.The text was updated successfully, but these errors were encountered: