Add support for text events #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for `navigator.sendBeacon` sent events. Currently Chrome limits the content types in `sendBeacon` for security reasons, so we cannot use json.
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
========================================
- Coverage 94.49% 92.1% -2.4%
========================================
Files 8 8
Lines 109 114 +5
========================================
+ Hits 103 105 +2
- Misses 6 9 +3
Continue to review full report at Codecov.
|
|
This looks good to me. Should we add a test? |
|
Using https://github.com/yoshuawuyts/microanalytics instead of the fair-analytics client would also be a good choice. Only problem I see is the sendBeacon API is not supported by all browsers, but this should be easily solvable with a polyfill |
|
Let's merge this one. |
|
@joehand I've released Edit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
navigator.sendBeaconsent events. Currently Chrome limits the content types insendBeaconfor security reasons, so we cannot use json. For example, we are looking at this client side library.We want to track outbound links and the best way to do that is with
sendBeacon. But json is not supported right now =(.If this is merged we'll probably use microanalytics on the client side but I can look into adding this to the fa client too!