Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "now" in function names to "commit" #11

Closed
vespertilian opened this issue Jan 22, 2019 · 0 comments
Closed

Change "now" in function names to "commit" #11

vespertilian opened this issue Jan 22, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@vespertilian
Copy link
Owner

Currently we use "Now" to signify that the function will commit. This comes from commitNow. In retrospect "Commit" is the better less ambiguous term.

From dgraph code here

If commitNow is set, then this call will result in the transaction being committed. In this case, an explicit call to commit doesn't need to subsequently be made.
@vespertilian vespertilian added the enhancement New feature or request label Jan 22, 2019
vespertilian added a commit that referenced this issue Apr 13, 2019
@vespertilian
feat(src/*): change now in function names to commit
5cab3f4 
This is to better match the dgraph api. Commit is a better term IMHO as it's less ambigous.

BREAKING CHANGE: Any function that previously had the word now, has the word commit in it instead.

#11
vespertilian added a commit that referenced this issue Apr 13, 2019
@vespertilian
Merge pull request #13 from vespertilian/add-more-docs
d7f0e30 
Add more docs also change now to commit issue #11
vespertilian added a commit that referenced this issue Apr 13, 2019
@vespertilian
feat(src/*): change now in function names to commit
2f66e99 
This is to better match the dgraph api. Commit is a better term IMHO as it's less ambigous.

BREAKING CHANGE: Any function that previously had the word now, has the word commit in it instead.

#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vespertilian