Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOV-Id Modal: Select2 does not always initialize #9

Closed
ric2016 opened this issue Apr 6, 2020 · 7 comments
Closed

GOV-Id Modal: Select2 does not always initialize #9

ric2016 opened this issue Apr 6, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@ric2016
Copy link
Contributor

ric2016 commented Apr 6, 2020

See screenshot. Other select2 components seem to work.

image

Occurs at https://www.genealogie-roy-ramet.com/tree/roy-ramet/individual/X5456/Antoinette%20BOST

Refactor the initialization logic closer to regular modals/ select2 components.

@ro-la
Copy link
Contributor

ro-la commented Apr 10, 2020

Just for protocol very similary/the same problem in webtrees: fisharebest/webtrees#2935

ric2016 added a commit that referenced this issue Apr 13, 2020
@ric2016
Copy link
Contributor Author

ric2016 commented Apr 13, 2020

Fixed in the latest release.

@ric2016 ric2016 closed this as completed Apr 13, 2020
@ric2016 ric2016 reopened this Apr 19, 2020
@ric2016
Copy link
Contributor Author

ric2016 commented Apr 19, 2020

Still buggy for edit control within other modals ("Create Shared Place").

@ric2016 ric2016 added the bug Something isn't working label Apr 19, 2020
@ric2016
Copy link
Contributor Author

ric2016 commented Apr 20, 2020

To summarize, the custom select2 control is used in 4 different contexts:

  1. When a GOV-Id of a shared place is edited, as a fact (non-modal)
  2. When a GOV-Id is edited via the facts & events tab (within its own modal)
  3. When a GOV-Id is set when creating a new shared place (within the shared place's modal, opened via the shared places list)
  4. When a GOV-Id is set when creating a new shared place (within the shared place's modal, opened via the facts and events tab)

The latter two require a custom modal placeholder (default placeholder would be webtrees' ajax.phtml) which allows the initialization of custom select2 controls (ajax-modal-vesta.phtml, in vesta-common).

@ric2016
Copy link
Contributor Author

ric2016 commented Apr 26, 2020

Finally fixed in latest release.

@ric2016
Copy link
Contributor Author

ric2016 commented May 7, 2020

Again: Still buggy for edit control within other modals (Use Case 4 in #9 (comment)).
(see ric2016/shared_places#8)

@ric2016
Copy link
Contributor Author

ric2016 commented May 9, 2020

Finally (hopefully!) fixed in latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants