Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected tag _GOVTYPE #17

Closed
hartenthaler opened this issue Jul 13, 2020 · 2 comments
Closed

unexpected tag _GOVTYPE #17

hartenthaler opened this issue Jul 13, 2020 · 2 comments

Comments

@hartenthaler
Copy link

There was an illegal GEDCOM structure in a shared place record (manually entered by me):
1 _LOC X164
2 _GOVTYPE POLI

it should be
1 _LOC @X164@
2 TYPE POLI

When I tried to edit this element the following error was raised (maybe this error can be catched):

unexpected tag: _GOVTYPE …/modules_v4/vesta_shared_places/patchedWebtrees/Functions/FunctionsEditLoc.php:195 #0 …/modules_v4/vesta_shared_places/patchedWebtrees/Functions/FunctionsEditLoc.php(84): Cissee\WebtreesExt\Functions\FunctionsEditLoc::addSimpleTagWithGedcomRecord(Object(Cissee\WebtreesExt\SharedPlace), Object(Cissee\WebtreesExt\CustomTree), '2 _GOVTYPE POLI', '_LOC', '<span class="er...') vesta-webtrees-2-custom-modules/vesta_gov4webtrees#1 …/modules_v4/vesta_shared_places/resources/views/edit/edit-fact.phtml(36): Cissee\WebtreesExt\Functions\FunctionsEditLoc::createEditFormLoc(Object(Fisharebest\Webtrees\Fact)) vesta-webtrees-2-custom-modules/vesta_gov4webtrees#2 …/app/View.php(186): include('/mnt/web312/a3/...') vesta-webtrees-2-custom-modules/vesta_gov4webtrees#3 …/app/View.php(282): Fisharebest\Webtrees\View->render() vesta-webtrees-2-custom-modules/vesta_gov4webtrees#4 …/app/Helpers/functions.php(203): Fisharebest\Webtrees\View::make('edit/edit-fact', Array) vesta-webtrees-2-custom-modules/vesta_gov4webtrees#5 …/app/Http/ViewResponseTrait.php(51): view('edit/edit-fact', Array) vesta-webtrees-2-custom-modules/vesta_personal_facts#3 …/app/Http/RequestHandlers/EditFactPage.php(82): Fisharebest\Webtrees\Http\RequestHandlers\EditFactPage->viewResponse('edit/edit-fact', Array) vesta-webtrees-2-custom-modules/vesta_gov4webtrees#7 …/app/Http/Middleware/WrapHandler.php(83): Fisharebest\Webtrees\Http\RequestHandlers\EditFactPage->handle(Object(Nyholm\Psr7\ServerRequest))

@ric2016
Copy link
Contributor

ric2016 commented Jul 13, 2020

Yes - unexpected tags should not cause errors.

By the way, nested shared places like this will be supported in the next release, which should be available shortly.

@ric2016 ric2016 transferred this issue from vesta-webtrees-2-custom-modules/vesta_gov4webtrees Jul 13, 2020
@ric2016
Copy link
Contributor

ric2016 commented Jul 17, 2020

Fixed in latest release (2.0.6.2.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants