B: 2 - Migrated sample project view bindings to butterknife. Closes #11 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vestrel00
changed the title
vestrel00
commented
Jul 27, 2017
| * onViewStateRestored | ||
| * onResume | ||
| */ | ||
| viewUnbinder = ButterKnife.bind(this, getView()); |
There was a problem hiding this comment.
Use the view instead of calling getView() again.
There was a problem hiding this comment.
Shouldn't be onStart between onViewStateRestoredand onResume?
There was a problem hiding this comment.
Yes. I didn't include onStart because it wasn't relevant here. I also omitted onCreate on purpose.
vestrel00
commented
Jul 27, 2017
| * | ||
| * If we bind before this method (e.g. onViewCreated), then any checked changed | ||
| * listeners bound by ButterKnife will be invoked during fragment recreation (since | ||
| * Android itself saves and restores the views' states. |
There was a problem hiding this comment.
Missing closing parenthesis.
vestrel00
commented
Aug 14, 2017
| public void onViewStateRestored(Bundle savedInstanceState) { | ||
| super.onViewStateRestored(savedInstanceState); | ||
| View view = getView(); | ||
| if (view != null) { |
There was a problem hiding this comment.
Null check not needed since onViewStateRestored only gets called when the View returned in onCreateView is not null. See 7370d99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated sample project view bindings to butterknife.