Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GroupsUpdate API allows updating read-only groups, which results in a falsely successful operation #305

Closed
vestrel00 opened this issue Aug 31, 2023 · 1 comment
Closed

GroupsUpdate API allows updating read-only groups, which results in a falsely successful operation #305

vestrel00 opened this issue Aug 31, 2023 · 1 comment
Assignees
@vestrel00
Labels
bug Something isn't working
Projects
General maintenance

Comments

@vestrel00
Copy link
Owner

Problem

Updating system, read-only Groups using the GroupsUpdate API seems to succeed...

  • The operation succeeds and throws no error or exceptions.
  • The group title is updated to the new value LOCALLY in the Contacts Provider Groups table.

HOWEVER, the title change does not actually get applied to the remote sync servers.

Here is the scenario,

  1. Change the title of a system, read-only group using GroupsUpdate. For example, change title "Friends" to "Enemy".
  2. Operation succeeds and the group title is now "Enemy" in the local Contacts Provider database.
  3. ❌ The group title in other devices that is logged into the same Account is still "Friends" even after triggering contacts sync in the system account settings on both devices.
  4. ❌ The group title reverts back to "Friends" after removing the Account and adding it back in.

Solution

Fail the GroupsUpdate operation for groups that are read-only to ensure users do not falsely believe that the operation actually succeeded.
@vestrel00 vestrel00 added the bug Something isn't working label Aug 31, 2023
@vestrel00 vestrel00 self-assigned this Aug 31, 2023
@vestrel00 vestrel00 added this to In progress in General maintenance Aug 31, 2023
@vestrel00 vestrel00 moved this from In progress to Done in General maintenance Aug 31, 2023
vestrel00 added a commit that referenced this issue Sep 1, 2023
@vestrel00
Closes #310 Rename readOnly property of GroupEntity to isReadOnly and…
78032ba 
… ReadOnly of GroupsFields to GroupIsReadOnly (related to #305 and #306)
@vestrel00
Copy link
Owner Author

🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥
This is now release in 0.3.1!
🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vestrel00 vestrel00

Labels
bug Something isn't working
Projects
General maintenance
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vestrel00