Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting ContactsContract.CALLER_IS_SYNCADAPTER in all CRUD APIs #308

Closed
6 tasks done
vestrel00 opened this issue Sep 1, 2023 · 1 comment
Closed
6 tasks done

Support setting ContactsContract.CALLER_IS_SYNCADAPTER in all CRUD APIs #308

vestrel00 opened this issue Sep 1, 2023 · 1 comment
Assignees
@vestrel00
Labels
enhancement New feature or request
Projects
General maintenance

Comments

@vestrel00
Copy link
Owner

vestrel00 commented Sep 1, 2023 •
edited

Problem

As discussed in #301, read-only Data rows can only be updated when ContactsContract.CALLER_IS_SYNCADAPTER is set to true for the update operation. With the addition of #306, users will be able to insert read-only Data rows. However, they (sync adapters) will not be able to update them.

Solution

Add a property called isSyncAdapter to the contacts.core.Contacts API that can be set during API instance initialization. Use it to set the value of ContactsContract.CALLER_IS_SYNCADAPTER in all CRUD APIs provided in the library.

  • Update relevant in-code documentation.
  • Update relevant docs (setup-contacts-api.md, about-api-entities.md)
  • Document supported/known CRUD API changes when it is set to true.
  • Document that this should only be set to true when using in the context of sync adapter use cases. This is NOT for general application use cases!
  • Close Custom data integrations now require callerIsSyncAdapter: Boolean parameter #313
  • Update gh-page branch
@vestrel00 vestrel00 added the enhancement New feature or request label Sep 1, 2023
@vestrel00 vestrel00 self-assigned this Sep 1, 2023
This was referenced Sep 1, 2023
Closed
Closed
@vestrel00 vestrel00 moved this from To do to In progress in General maintenance Sep 5, 2023
@vestrel00 vestrel00 mentioned this issue Sep 5, 2023
Closed
2 tasks
vestrel00 added a commit that referenced this issue Sep 7, 2023
@vestrel00
Fixed compile-error due to uncommited changes for #308
b3dcbec
@vestrel00 vestrel00 moved this from In progress to Done in General maintenance Sep 7, 2023
@vestrel00
Copy link
Owner Author

🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥
This is now release in 0.3.1!
🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vestrel00 vestrel00

Labels
enhancement New feature or request
Projects
General maintenance
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vestrel00