Closes #150; Concise alternative to FieldsWhere.kt #163
Conversation
vestrel00
added
code quality
| * operators on multiple fields of a [FieldSet]. | ||
| */ | ||
| inline operator fun <T : Field, FS : FieldSet<T>> FS.invoke(where: FS.() -> Where<T>): Where<T> = | ||
| where(this) |
There was a problem hiding this comment.
10/10 implementation and documentation. Thank you!
| @@ -1,570 +0,0 @@ | |||
| @file:Suppress("FunctionName") | |||
There was a problem hiding this comment.
Really good thing that I asked about this on Reddit! You have literally reduced ~500 lines of code down to 2 lines. I have no words. I learned something from this! I don't know everything about Kotlin magic!
I have given you a gold medal for this. Thank you ❤️
I want to give you 50,000 points but I don't have money 😄
There was a problem hiding this comment.
That is true, sometimes seemingly random things lead us to some interesting places and situations, this time it was Reddit.
Thank you so much for your appreciation. You are too kind and wholesome.
I'm already chuffed to bits with your responses, they mean a whole lot more to me than Reddit awards. But still, thank you for taking time out and showing appreciation the way you did, be it on Reddit or on GitHub.
This was my first Open Source contribution (other than my own projects), I'm glad it worked out for both of us the way it did ❤️.
This PR brings in a more concise and maintainable way of doing what
contacts.core.util.FieldsWhere.ktextensions are doing.More details are discussed in here #162 and here #150.
As discussed prior, the new extensions are added in the
contacts.core.Where.ktfile and thecontacts.core.util.FieldsWhere.ktfile has been removed in favor of the new extensions.