Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update banner logo #794

Merged
merged 9 commits into from Aug 8, 2018
Merged

Update banner logo #794

merged 9 commits into from Aug 8, 2018

Conversation

smcmurtry
Copy link
Collaborator

Closes #781

@sastels sastels temporarily deployed to vac-poc-staging-pr-794 August 3, 2018 19:03 Inactive
@sastels
Copy link
Collaborator

sastels commented Aug 4, 2018

Can we get it to shrink a bit like the old one did?

image

@sastels sastels requested a deployment to vac-poc-pr-794 August 4, 2018 13:33 Abandoned
@sastels sastels temporarily deployed to vac-poc-staging-pr-794 August 6, 2018 18:09 Inactive
@maxneuvians
Copy link
Contributor

Need to close and open to kick the heroku PR app

@maxneuvians maxneuvians closed this Aug 7, 2018
@maxneuvians maxneuvians reopened this Aug 7, 2018
@maxneuvians
Copy link
Contributor

maxneuvians commented Aug 7, 2018 •
edited

Can we delete these files?

../static/vac-sig-eng-2018.svg
../static/vac-sig-eng-2018-white.svg
../static/vac-sig-fra-2018-white.svg

Otherwise looks great!

@smcmurtry
Copy link
Collaborator Author

Awesome work getting that FIP component to work!

@smcmurtry smcmurtry merged commit 0221010 into master Aug 8, 2018
@smcmurtry smcmurtry deleted the update_banner_logo branch August 8, 2018 17:15
danprime pushed a commit to code-for-canada/vac-benefits-directory that referenced this pull request Aug 13, 2018
@smcmurtry @danprime
Update banner logo (veteransaffairscanada#794)
310ab1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomascraig thomascraig thomascraig approved these changes

@maxneuvians maxneuvians Awaiting requested review from maxneuvians

@sastels sastels Awaiting requested review from sastels

@apmcguigan apmcguigan Awaiting requested review from apmcguigan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smcmurtry @sastels @maxneuvians @thomascraig