Number being cast to string causes domain filter to be applied incorrectly

[tiaanduplessis]

Thank you for maintaining this package. When trying to apply a domain filter that has an integer value e.g.

odoo.searchRead(`hr.job`, {  company_id: 1 }, fields, params)

The typecasting to a string of the value happening (https://github.com/vettloffah/odoo-await/blob/master/lib/index.js#L252) leads to incorrect results being returned.

When removing this typecasting:

domainArray.push([`${key}`, '=', value]);

I receive the correct results.

If you are currently unable to assist with an update, I will be more than happy to create a PR.

[vettloffah]

Ah! Nice catch. I'll work this in to the next update which should be today or tomorrow.

…

On Wed, Jan 27, 2021 at 12:35 PM Tiaan ***@***.***> wrote: Thank you for maintaining this package. When trying to apply a domain filter that has an integer value e.g. odoo.searchRead(`hr.job`, { company_id: 1 }, fields, params) The typecasting to a string of the value happening ( https://github.com/vettloffah/odoo-await/blob/master/lib/index.js#L252) leads to incorrect results being returned. When removing this typecasting: domainArray.push([`${key}`, '=', value]); I receive the correct results. If you are currently unable to assist with an update, I will be more than happy to create a PR. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYFFLFMWUUYBCR5OIXVNZTS4BFHHANCNFSM4WVU2QFQ> .

[tiaanduplessis]

Awesome! Thanks for the quick response 👍

[vettloffah]

Resolved with version 2.1.1 (somehow missed this in the last update)