Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with AboutPSObjects #191

Closed
arefg opened this issue May 27, 2019 · 0 comments · Fixed by #228
Closed

Issues with AboutPSObjects #191

arefg opened this issue May 27, 2019 · 0 comments · Fixed by #228
Labels
Category-Koans Invoking the Great Doubt Issue-Bug 🐛 Something's wrong! Up For Grabs / Hacktoberfest 💻 If it's Up For Grabs, take it and run with it! If not, ask if it's in progress / you can take it.

Comments

@arefg
Copy link

arefg commented May 27, 2019

Line 43: All __ should be '__' and since the order is important we need to bring the 'Count' to the top:

    $PropertyNames = @(
        'Count'
        '__'
        'LongLength'
        '__'
        'SyncRoot'
        '__'
        'IsFixedSize'
        '__'
    )

Line 56: Methods.Count returns an array of ones @(1,1,1,1,...) so either we need to change line 55 to this:

           $Methods = $Object.PSObject.Methods.Name

to just get the names of the methods and change line 57 to this

          $Methods[__] | Should -Be 'get_Length'

Line 66 has the same order problem and there is an extra blank space in it and also IsSynchronized is spelled with s instead of z. It should be like this:

          @('__', '__', '__', '__', '__', 'IsReadOnly', '__', 'IsSynchronized') | Should -Be $Empty.PSObject.Properties.Name

Line 100: There should be 3 blank space because there are 3 property types('NoteProperty', 'AliasProperty', 'Property').

           @( '__', '__', '__' ) | Should -Be $PropertyTypes

Line 117: There should be 4 blank space because there are 4 property types('ScriptProperty', 'NoteProperty', 'AliasProperty', 'Property').

           @( '__', '__', '__', '__') | Should -Be $PropertyTypes
@vexx32 vexx32 added Category-Koans Invoking the Great Doubt Issue-Bug 🐛 Something's wrong! Up For Grabs / Hacktoberfest 💻 If it's Up For Grabs, take it and run with it! If not, ask if it's in progress / you can take it. labels May 31, 2019
@vexx32 vexx32 added this to To do in Koan Topic Tracking via automation Jun 11, 2019
vercellone added a commit to vercellone/PSKoans that referenced this issue Aug 28, 2019
Koan Topic Tracking automation moved this from To do to Done Aug 31, 2019
vexx32 pushed a commit that referenced this issue Aug 31, 2019
* fixes #191 AboutPSObjects

* reorder static arrays alphabetically

* changes requested by @vexx32

* single line feed before EOF

* fix-count-ienumerable

* varying property types comment

* Moved varying PropertyTypes comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Koans Invoking the Great Doubt Issue-Bug 🐛 Something's wrong! Up For Grabs / Hacktoberfest 💻 If it's Up For Grabs, take it and run with it! If not, ask if it's in progress / you can take it.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants