Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write Tests for *-Advice Cmdlets #278

Closed
vexx32 opened this issue Oct 2, 2019 · 0 comments · Fixed by #283
Closed

Write Tests for *-Advice Cmdlets #278

vexx32 opened this issue Oct 2, 2019 · 0 comments · Fixed by #283
Labels
Category-Tests ✅ Pertaining to tests for the module functions. Good First Issue ❇️ Should be quick and easy! Issue-Enhancement 🎉 Make it better!
Projects
Module Features / Bugfixes Progress

Comments

@vexx32
Copy link
Owner

vexx32 commented Oct 2, 2019

Describe "Functionality"

The *-Advice public commands do not have any tests verifying their behaviour.

Context "Private or Public? What are the use cases? Parameters? Options?"

Show-Advice and Register-Advice are public module functions.
Both are completely lacking any tests as of yet.
Refer to each command's documentation and working code to determine appropriate tests.
@vexx32 vexx32 added Issue-Enhancement 🎉 Make it better! Up For Grabs / Hacktoberfest 💻 If it's Up For Grabs, take it and run with it! If not, ask if it's in progress / you can take it. Category-Tests ✅ Pertaining to tests for the module functions. Hacktoberfest labels Oct 2, 2019
@vexx32 vexx32 added this to Needs triage in Module Features / Bugfixes Progress via automation Oct 2, 2019
@vexx32 vexx32 added the Good First Issue ❇️ Should be quick and easy! label Oct 2, 2019
@vexx32 vexx32 moved this from Needs triage to Low priority in Module Features / Bugfixes Progress Oct 2, 2019
@vexx32 vexx32 mentioned this issue Oct 2, 2019
Merged
5 tasks
manoj2994 added a commit to manoj2994/PSKoans that referenced this issue Oct 8, 2019
@manoj2994
Write Tests for *-Advice Cmdlets vexx32#278
1740f99 
Created Tests FOr Show-Advice and Register-Advice with the possibilities of chances for execution and made a chane on the Register-Advice function where Select-String '-Path' will only accept pipeline by property name.
@manoj2994 manoj2994 mentioned this issue Oct 8, 2019
Merged
@vexx32 vexx32 removed Hacktoberfest Up For Grabs / Hacktoberfest 💻 If it's Up For Grabs, take it and run with it! If not, ask if it's in progress / you can take it. labels Oct 8, 2019
@vexx32 vexx32 moved this from Low priority to In Progress in Module Features / Bugfixes Progress Oct 8, 2019
manoj2994 added a commit to manoj2994/PSKoans that referenced this issue Oct 11, 2019
@manoj2994
Write Tests for *-Advice Cmdlets vexx32#278
e85ec85 
Created Tests FOr Show-Advice and Register-Advice with the possibilities of chances for execution and made a chane on the Register-Advice function where Select-String '-Path' will only accept pipeline by property name.
Module Features / Bugfixes Progress automation moved this from In Progress to Closed Oct 14, 2019
vexx32 pushed a commit that referenced this issue Oct 14, 2019
@manoj2994 @vexx32
✅ Write Tests for *-Advice Cmdlets #278 (#283)
d0726f5 
* Write Tests for *-Advice Cmdlets #278

Created Tests For Show-Advice and Register-Advice with the possibilities of chances for execution and made a change on the Register-Advice function where Select-String '-Path' will only accept pipeline by property name.

* Added Before all blocks for the tests

* Updated the beforeall blocks in register-advice

* Update on Beforeblock tests on reister-advice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category-Tests ✅ Pertaining to tests for the module functions. Good First Issue ❇️ Should be quick and easy! Issue-Enhancement 🎉 Make it better!
Projects
Module Features / Bugfixes Progress
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Write Tests for *-Advice Cmdlets #278 manoj2994/PSKoans
1 participant
@vexx32