Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change addition array example - fixes #111 #112

Merged
merged 3 commits into from Dec 19, 2018
Merged

Change addition array example - fixes #111 #112

merged 3 commits into from Dec 19, 2018

Conversation

thomasrayner
Copy link
Contributor

No description provided.

@vexx32 vexx32 closed this Dec 19, 2018
@vexx32 vexx32 reopened this Dec 19, 2018
vexx32
vexx32 requested changes Dec 19, 2018
View reviewed changes
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking over the example and intent that can be inferred from the comment, I think your initial idea in #111 is a better fit here.

PSKoans/Koans/Foundations/AboutAssignmentAndArithmetic.Koans.ps1 Outdated Show resolved Hide resolved
@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Koans Invoking the Great Doubt PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. labels Dec 19, 2018
@vexx32 vexx32 added this to the v0.43.0 milestone Dec 19, 2018
@vexx32 @thomasrayner
Update PSKoans/Koans/Foundations/AboutAssignmentAndArithmetic.Koans.ps1
40b83a3 
Co-Authored-By: thomasrayner <thmsrynr@outlook.com>
@thomasrayner
Copy link
Contributor Author

I like that better, too. I think it's more readable for people newer to PowerShell.

vexx32
vexx32 approved these changes Dec 19, 2018
View reviewed changes
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is much more clear (and actually works lol)!

@vexx32 vexx32 merged commit df3cc36 into vexx32:master Dec 19, 2018
@vexx32 vexx32 removed PR-Needs-Review 🔍 Let's take a closer look! PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. labels Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vexx32 vexx32 vexx32 approved these changes

Assignees

@thomasrayner thomasrayner

Labels
Category-Koans Invoking the Great Doubt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomasrayner @vexx32