Remove unneeded wait periods #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now should return pretty much as soon as the threaded task is completed - Remove reference to runspacePool that isn't being used here.
vexx32
added
PR-Needs-Review 🔍
|
@vexx32 Did you notice much of a performance increase after making this change? Super curious about it. I was planning on digging into |
steviecoaster
previously approved these changes
Dec 19, 2018
|
Get those checks working so you can merge it :) |
|
@thomasrayner it helps somewhat. If you want to speed it up any further than this, you probably can, but check into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start-Sleepperiods fromShow-MeditationPromptInvoke-Koanso that it can return as soon as it detects the threaded job's completion./cc @markekraus @thomasrayner