Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat Koans to report better error messages #115

Merged
merged 1 commit into from Dec 20, 2018
Merged

Reformat Koans to report better error messages #115

merged 1 commit into from Dec 20, 2018

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Dec 20, 2018

  • Should error messages changed to list expected values in a more sensible fashion

@vexx32
KOAN: Reformat tests
2bc6a8c 
- Should error messages list expected values in a more sensible fashion
@vexx32 vexx32 self-assigned this Dec 20, 2018
@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Koans Invoking the Great Doubt labels Dec 20, 2018
@vexx32 vexx32 added this to the v0.43.0 milestone Dec 20, 2018
steviecoaster
steviecoaster approved these changes Dec 20, 2018
View reviewed changes
Copy link
Collaborator

@steviecoaster steviecoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer throughout.

@vexx32
Copy link
Owner Author

vexx32 commented Dec 20, 2018

<3

@vexx32 vexx32 merged commit a3d6eb7 into master Dec 20, 2018
@vexx32 vexx32 deleted the InvertShouldLogic branch December 20, 2018 18:16
@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviecoaster steviecoaster steviecoaster approved these changes

Assignees

@vexx32 vexx32

Labels
Category-Koans Invoking the Great Doubt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vexx32 @steviecoaster