Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Dummy types (incl. [__]) globally #122

Merged
merged 2 commits into from Jan 4, 2019
Merged

Load Dummy types (incl. [__]) globally #122

merged 2 commits into from Jan 4, 2019

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Jan 4, 2019

This is necessary for Pester's -BeOfType to see them.

We can load them conditionally that a type of the same name isn't already loaded with a simple switch, but they need to be in the global scope for Pester's commands to be able to see them.

using module won't allow these commands to see the types borrowed from PSKoans in the current scope, it appears to only check types available in Pester's module scope.

@vexx32 vexx32 self-assigned this Jan 4, 2019
@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Module Pertaining to the module's functionality itself. labels Jan 4, 2019
@vexx32 vexx32 added this to the v0.43.0 milestone Jan 4, 2019
@vexx32
Copy link
Owner Author

vexx32 commented Jan 4, 2019

Confirmed that problematic file AboutVariables.Koans.ps1 now is assessed correctly and the types are properly recognised.

@vexx32 vexx32 merged commit 157baa8 into master Jan 4, 2019
@vexx32 vexx32 deleted the FixDummyTypes branch January 4, 2019 17:22
@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Module Pertaining to the module's functionality itself.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant