-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Data Strings & Show-MeditationPrompt #126
Conversation
✨ Added some extra color to the koan quotes! 🔧 Fix sporadic class import issues
Failing build is due to issue with BuildHelpers module used for CI. Looks like @RamblingCookieMonster has been tinkering around, and for whatever reason one of the build variables isn't able to be bound to a string despite confirming it's not null. One of these sections seems to be the culprit (Error talks about parameter binding exception for a |
@vexx32 Have you considered manipulating the background color in addition to the foreground color? Some of your choices might look a little wonky for folks using different themes (like some of the high contrast ones). |
@thomasrayner I've considered it, but taking into account the fact that those colors may also be modified from the defaults arbitrarily, I'm not sure what I can do in terms of making sure it remains readable? |
@vexx32 If $psrlModule = Get-Module PSReadLine
if (-not $psrlModule) {
return
}
$options = Get-PSReadLineOption
if ($psrlModule.Version.Major -ge 2) {
# Handle as ANSI escape
return '{1}Colored like a number{0} {2}Colored like a keyword{0}' -f (
"$([char]27)[0m", # Reset color ANSI escape
$options.NumberColor,
$options.KeywordColor)
} else {
# Handle like ConsoleColor
} |
That... is complicated. But I appreciate the pointer! I'll copy it to an issue so I can keep track of it, but it probably won't happen anytime soon 😕 |
Maybe in the meantime, it would be easier to implement a |
🤔 Yeah, I can see why you'd need that, I suppose. I'll think on it. 😄 |
Just to eliminate all the colors in general and use whatever bland colors the console is set to. Maybe colorblind people have a setting they like and are annoyed by the fanciness 🤷♂️ |
See #127. Yep, the option will be there... sooner or later 😉 |
New design:
![image](https://user-images.githubusercontent.com/32407840/50946761-e3a66d00-1468-11e9-8a99-b7d2397df2f5.png)
Also moved all data strings to PSD1 data file for cleanliness.