Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dbatools Koans #140

Merged
merged 135 commits into from
May 19, 2020
Merged

Add Dbatools Koans #140

merged 135 commits into from
May 19, 2020

Conversation

shaneis
Copy link
Contributor

@shaneis shaneis commented Mar 5, 2019

All those other dopamine hits are just pretenders!

🎆 🍾

First commit for visibility, guidance, and anything else you can think of @vexx32

Pulling from Joel's dbatools again
@vexx32
Copy link
Owner

vexx32 commented Apr 7, 2020

@shaneis looks much better! Final cleanliness point would just be renaming files to About*.Koans.ps1 rather than just About*.ps1 (yes I'm picky as hell, I'm sorry!) 😂

@shaneis
Copy link
Contributor Author

shaneis commented Apr 8, 2020

🤔 I swear I did that already? Not a problem, I'll rename them 👍

@shaneis
Copy link
Contributor Author

shaneis commented Apr 21, 2020

I think I have all the changes put in. Should be ready for another review 👍

@shaneis shaneis requested a review from vexx32 April 21, 2020 10:45
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💖 😊

Solid work, and thanks for putting up with my nitpicking 😁

@potatoqualitee did you want to have a look through before I merge this?

@shaneis
Copy link
Contributor Author

shaneis commented Apr 23, 2020

Looks good to me! 💖 😊

Solid work, and thanks for putting up with my nitpicking 😁

@potatoqualitee did you want to have a look through before I merge this?

What nitpicking? Not a single negative remark, all positive suggestions. I loved doing this PR!

@vexx32
Copy link
Owner

vexx32 commented May 19, 2020

Let's merge this before I forget again. 😂

@potatoqualitee at some point it might be interesting to chat about moving module-specific commands to individual modules themselves; would be good to get your thoughts on that if you're interested.

Might get a few more written by the community if they're visible / maintained in the main dbatools repo, I'd think. 🤔

Then again, this module would be helpful and/or required for making them work well, so... 🤷

@vexx32 vexx32 merged commit cc41ad3 into vexx32:master May 19, 2020
Koan Topic Tracking automation moved this from In progress to Done May 19, 2020
@shaneis shaneis deleted the dbatools branch May 19, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Koans Invoking the Great Doubt PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants