Clarify AboutPSProviders->FileSystemProvider Koan.

[ghost]

PR Summary

Resolves #174

Instead of using the TempDrive created by Pester, added logic to determine execution environment and use the local temp directory.

Instead of dynamically creating a text file, replaced with static lines of text. Makes the following tests clearer.

Context

Changes

• Replaced dynamically generated file with static text.

Checklist

• Pull Request has a meaningful title.
• Summarised changes.
• Pull Request is ready to merge & is not WIP.
• Added tests / only testable interactively.
  • Make sure you add a new test if old tests do not effectively test the code changed.
• Added documentation / opened issue to track adding documentation at a later date.

[vexx32]

I like the look of this so far!

We may need to change tack a bit, as I'd like to keep boilerplate code out of the koan files themselves as much as we can.

[vexx32]

Looking pretty good, just want to make sure we're headed the right direction here. Appreciate your efforts so far! 😊

[vexx32]

🤔 Hmm, looks like you pulled in some commits with a merge or something? You might need to rebase -i master or something and trim those out. 🙂

[nohwnd]

Switch to this branch. Then do git branch "file-system-provider-backup". This will checkout another branch from this branch to make sure you don't lose the commits. Then do git reset head~3 to reset the last 3 commits, then git stash -u and git stash drop to throw away the changes coming from the last three commits. if you now do git log you should see the commits first two commits but not the last three. once you are happy git push --force-with-lease to update the branch on the remote, which will also update this merge request. (or you can do rebase but that would mean that you'd need to solve merge conflicts if there were any, so this approach seems easier :D)

[vexx32]

Yeah but then he'd lose also his actual last commit. Rebase is simpler in my mind... Eh, whatever works. :P

[nohwnd]

Ah okay, there we commits to keep. In that case interactive rebase is indeed simpler.

[ghost]

@vexx32 Yeah, instead of doing git pull like i should have to update my local branch to the changes of the project master, I did git fetch then git rebase FETCH_HEAD thinking I would be able to skip a merge commit. Long story short, just being a dummy. At this point, I think the issue related to this Pull Request is actually resolved AND git history is coherent. Let me know if you want anything done differently.

@nohwnd I haven't used git push --force-with-lease before / didn't know it existed. Thanks for the advanced! Worked well.

[vexx32]

Looks good! Minor nit but otherwise we're all good.

Thanks so much! 😄

[vexx32]

Love it, thank you!