Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed out-file parameter and updated Out-String koan #198

Merged
merged 3 commits into from Jun 11, 2019
Merged

Changed out-file parameter and updated Out-String koan #198

merged 3 commits into from Jun 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 6, 2019

PR Summary

Resolves #197

Context

Out-String Koan is changed in its approach as carriage returns are "funny" and potentially confusing when trying to compare Get-Item output in a here string. The idea is if the here string is static, then the user only has to update what is piping into out-string. Since this koan is about out-string this feels appropriate.

Changes

  • Changed Out-File parameter from -Path to -FilePath to support Windows PowerShell 5.1 and earlier.
  • Changed Out-String koan to not require here-string edits, instead requires updates to what is piped into Out-String.

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@ghost ghost requested review from steviecoaster and vexx32 as code owners June 6, 2019 03:31
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Couple minor things we can improve here, but definitely a step in a much better direction! 😍

PSKoans/Koans/Cmdlets 2/AboutOutCmdlets.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Cmdlets 2/AboutOutCmdlets.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Cmdlets 2/AboutOutCmdlets.Koans.ps1 Outdated Show resolved Hide resolved
vexx32
vexx32 previously approved these changes Jun 8, 2019
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

One very minor whitespace nit and we're good to merge. Thanks so much!

PSKoans/Koans/Cmdlets 2/AboutOutCmdlets.Koans.ps1 Outdated Show resolved Hide resolved
@vexx32 vexx32 added Category-Koans Invoking the Great Doubt PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. labels Jun 8, 2019
vexx32
vexx32 previously approved these changes Jun 9, 2019
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final thing, but super tiny.

Looks awesome, thank you! 😄

Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thank you very much! 😄

@vexx32 vexx32 merged commit 3320e2c into vexx32:master Jun 11, 2019
@vexx32 vexx32 removed the PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. label Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Koans Invoking the Great Doubt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AboutOutCmdlets
1 participant