-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed out-file parameter and updated Out-String koan #198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Couple minor things we can improve here, but definitely a step in a much better direction! 😍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
One very minor whitespace nit and we're good to merge. Thanks so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final thing, but super tiny.
Looks awesome, thank you! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you very much! 😄
PR Summary
Resolves #197
Context
Out-String Koan is changed in its approach as carriage returns are "funny" and potentially confusing when trying to compare Get-Item output in a here string. The idea is if the here string is static, then the user only has to update what is piping into out-string. Since this koan is about out-string this feels appropriate.
Changes
Checklist