Fixed typos, split ErrorRecord describe into two Contexts #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
vexx32
requested changes
Jun 8, 2019
PSKoans/Koans/Constructs and Patterns/AboutErrorHandling.Koans.ps1
Outdated
Show resolved
Hide resolved
| $_ | ||
| It 'sometimes has a reference to the object that caused the error' { | ||
| # But not always! | ||
| $Error[0].TargetObject | Should -BeNullOrEmpty |
There was a problem hiding this comment.
If we can have this as part of a separate test case that throws an error with no target object (I think simple throw statements don't assign a target object, possibly?) this might be better served.
If not, it might be better to remove this assertion.
There was a problem hiding this comment.
I agree with just removing that assertion all together. Since we have basically that same assertion on line 38.
PSKoans/Koans/Constructs and Patterns/AboutErrorHandling.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Constructs and Patterns/AboutErrorHandling.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Constructs and Patterns/AboutErrorHandling.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Constructs and Patterns/AboutErrorHandling.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Constructs and Patterns/AboutErrorHandling.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Constructs and Patterns/AboutErrorHandling.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Constructs and Patterns/AboutErrorHandling.Koans.ps1
Outdated
Show resolved
Hide resolved
vexx32
added
Category-Koans
….ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
….ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
….ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
….ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
….ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
….ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
….ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
vexx32
approved these changes
Jun 9, 2019
vexx32
removed
the
PR-Awaiting-Author ✏️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Resolves #196
Context
Couple of minor typos corrected. Big change to the Describe ErrorRecord koan as there was a mix of $Error and $ErrorRecord. Splitting them into separate contexts seems a more intuitive approach for the user.
Changes
Checklist