-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typos identified in Issue #190 #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Couple things here and there.
Thanks for taking care of this! 😊
PSKoans/Koans/Constructs and Patterns/AboutCustomObjects.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Constructs and Patterns/AboutCustomObjects.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Constructs and Patterns/AboutCustomObjects.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Constructs and Patterns/AboutCustomObjects.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Constructs and Patterns/AboutCustomObjects.Koans.ps1
Outdated
Show resolved
Hide resolved
….ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
….ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
….ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple final ones and then we're good to go.
Thank you! 😊
# What if we call it more than once? | ||
__ | Should -Be $Object.DerivedProperty | ||
'__' | Should -Be $Object.DerivedProperty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two should also not be strings. 🙂
__ | Should -Be $Object.CustomProperty | ||
__ | Should -Be $Object.BaseProperty | ||
'__' | Should -Be $Object.CustomProperty | ||
'__' | Should -Be $Object.BaseProperty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with these, these values are all numeric. :)
PSKoans/Koans/Constructs and Patterns/AboutCustomObjects.Koans.ps1
Outdated
Show resolved
Hide resolved
….ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! :)
PR Summary
Resolves #190
Context
Minor formatting changes and wording changes to clarify the CustomObject Koan.
Changes
Checklist