Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds OFS to AboutStrings #204

Merged
merged 6 commits into from
Jun 16, 2019
Merged

Adds OFS to AboutStrings #204

merged 6 commits into from
Jun 16, 2019

Conversation

indented-automation
Copy link
Contributor

PR Summary

Adds a short section about OFS

Context

Updates AboutStrings.Koans.ps1

Changes

  • Adds Arrays and Strings

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 😄

Couple comments, mostly trying to make sure wording isn't too confusing.

Also, thought I'd point out that we're trying to move towards the __ | Should -Be $ExpectedValue format as that's both a bit easier to parse looking at the files, and also tends to give more sensible errors from the pester tests, so the Measure-Karma output looks more sensible.

PSKoans/Koans/Foundations/AboutStrings.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Foundations/AboutStrings.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Foundations/AboutStrings.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Foundations/AboutStrings.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Foundations/AboutStrings.Koans.ps1 Outdated Show resolved Hide resolved
@vexx32 vexx32 added this to In progress in Koan Topic Tracking via automation Jun 15, 2019
@vexx32 vexx32 added Category-Koans Invoking the Great Doubt PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. labels Jun 15, 2019
indented-automation and others added 5 commits June 15, 2019 09:02
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 😄

@vexx32 vexx32 merged commit 21f8e42 into vexx32:master Jun 16, 2019
Koan Topic Tracking automation moved this from In progress to Done Jun 16, 2019
@vexx32 vexx32 removed the PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. label Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Koans Invoking the Great Doubt
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants