Fixes auto-succeeding pester tests in AboutComparison and AboutStrings

[EVWorth]

PR Summary

This PR fixes pester tests from auto-succeeding.

This PR Resolves Issues #212 and #213

I tested these changes to make sure they initially fail the pester tests successfully

Context

The solution for the AboutComparison issues came from: #212 (comment)

The solution for the AboutString issues came from: #213 (comment)

Changes

In AboutStrings:

• I replaced text in $String1 on line 105 that was causing the test to succeed without user input.

In AboutComparison.Koans.ps1

• I replaced 4 instances of __ with $__, where the pester tests were succeeding without user input, because __ was evaluating to $true which completed the test.

Checklist

• Pull Request has a meaningful title.
• Summarised changes.
• Pull Request is ready to merge & is not WIP.
• Added tests / only testable interactively.
  • Make sure you add a new test if old tests do not effectively test the code changed.
• Added documentation / opened issue to track adding documentation at a later date.

[vexx32]

Looks good! Can we use $____ rather than $__ (four underscores instead of two) just so it's very clear we're not trying to reference $_?

[EVWorth]

Good point/idea!

Done!

[vexx32]

Looks much better, thank you! 😄

One last one and this is good to merge!

[EVWorth]

I like the longer blanks. They stand out more which is always a good thing. Do you have a preference on standardizing the number of underscores?

perhaps 4 of each? ____ for int/double, "____" for string, and $____ for Boolean?

I know that the Foundations Koans could use a good freshening up in that regard. sounds like a project... 😄

[vexx32]

Looks good, thank you! 💖

[vexx32]

@EVWorth yeah it's changed over time as I realize this might be a bit clearer for various reasons. I'd say.... if we're expecting:

• Numeric input, go with __
• Strings, go with '____'
• Variables, go with $____
• Command names or strings in command arguments, go with ____ unless the string you expect would normally require quotes to enter it as a command argument.

Of course, with strings it's good to think about whether the string you expect might make use of interpolation and should thus use double quotes instead of single quotes. 🙂

[EVWorth]

Ok awesome. I'll use that going forward. I was thinking about the ' ' vs "" thing earlier. I think it makes sense to differentiate between those as well.

[vexx32]

🤔 Sigh, I need to add a contributing style guide lmao

[EVWorth]

If you do I'll contribute to it and ask you 50 billion questions you don't want to have to answer ;)

[vexx32]

I don't mind answering haha, it's all good. Just something I should do. I guess I'll make an issue so I don't forget. :)