Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AboutStringBuilder koans #225

Merged
merged 3 commits into from
Aug 15, 2019
Merged

Update AboutStringBuilder koans #225

merged 3 commits into from
Aug 15, 2019

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Aug 15, 2019 •
edited

PR Summary

Updates format and fixes some minor spelling / code errors in AboutStringBuilder koans to make it more usable.

Context

Resolves #188, superseding #202.

Changes

  • Updated style of blanks to current standards.
  • Fixed spelling / minor code errors.
  • Fixed xplat newline issue by avoiding literal here-string for the newlines.

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 mentioned this pull request Aug 15, 2019
Closed
5 tasks
@vexx32 vexx32 added Category-Koans Invoking the Great Doubt PR-Needs-Review 🔍 Let's take a closer look! labels Aug 15, 2019
@vexx32 vexx32 merged commit 9e01282 into master Aug 15, 2019
@vexx32 vexx32 deleted the StringBuilderFIxes branch August 15, 2019 20:11
@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviecoaster steviecoaster Awaiting requested review from steviecoaster

Assignees
No one assigned
Labels
Category-Koans Invoking the Great Doubt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with AboutStringBuilder
1 participant
@vexx32