Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce a single LF at EOF #232

Merged
merged 2 commits into from
Aug 31, 2019
Merged

Enforce a single LF at EOF #232

merged 2 commits into from
Aug 31, 2019

Conversation

vercellone
Copy link
Contributor

PR Summary

Implement Pester tests to enforce inclusion of a single line feed at the end of every script file. Exactly 1 line feed. No more. No less.

Context

As requested by @vexx32

Changes

  • Corrected line feeds in scripts that were non-compliant.
  • Added a LF test to ./Tests/KoanValidation.Tests.ps1
  • Added a LF test to ./Tests/ModuleValidation.Tests.ps1

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32
Copy link
Owner

vexx32 commented Aug 31, 2019

@vercellone looks like you still have the commit from your other PR. Can you run a git rebase -i and drop that commit? 🙂

@vercellone vercellone force-pushed the enforcelfeof branch 2 times, most recently from 71444af to f697c1a Compare August 31, 2019 04:23
vexx32
vexx32 previously approved these changes Aug 31, 2019
View reviewed changes
Copy link
Owner

@vexx32 vexx32 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me apart from the last CI error there. :)

Thanks! 💖

@vexx32 vexx32 merged commit 2b01ba4 into vexx32:master Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vexx32 vexx32 vexx32 approved these changes

@steviecoaster steviecoaster Awaiting requested review from steviecoaster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vercellone @vexx32