Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-platform building and testing #236

Merged
merged 7 commits into from
Sep 4, 2019
Merged

Add multi-platform building and testing #236

merged 7 commits into from
Sep 4, 2019

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Sep 4, 2019

PR Summary

We need to test the code on all the main supported platforms -- Windows/MacOS/Linux. This PR adds build jobs for each OS to build and test with.

Context

#234 details some outstanding issues with Mac support already. These may not be entirely avoidable with just CI testing, but this will go a long way into giving us early warning as to when something breaks.

Changes

  • Split out main build/test steps into template file.
  • Add agent jobs for each major OS supported by PowerShell Core.
  • Move publishing to gallery to a separate job, which depends on all the agent jobs completing successfully.

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

Add builds for MacOS and Windows
Move publishing module to new job entirely
Add steps to upload/download the help across jobs as an artifact
@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Build 🚀 Modifies the build / deployment system labels Sep 4, 2019
@vexx32 vexx32 merged commit 39aefd4 into master Sep 4, 2019
@vexx32 vexx32 deleted the CI/Platforms branch September 4, 2019 02:25
@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Build 🚀 Modifies the build / deployment system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant