Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use longer-form blank for dummy type name #244

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Use longer-form blank for dummy type name #244

merged 2 commits into from
Sep 13, 2019

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Sep 13, 2019

PR Summary

Adds the type ____ so that type blanks look a little more in line with current recommended format for text blanks (now using [____] rather than [__] to match '____').

Changes

  • Added ____ to DummyTypes.ps1
  • Changed all existing koans to use [____] instead of [__]
  • Retained [__] dummy type so old koans don't throw a fit and give Pester errors.

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

📝 Retain [__] for compat
@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Koans Invoking the Great Doubt Category-Module Pertaining to the module's functionality itself. labels Sep 13, 2019
@vexx32 vexx32 merged commit 9690b0a into master Sep 13, 2019
@vexx32 vexx32 deleted the BetterDummyType branch September 13, 2019 01:08
@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Koans Invoking the Great Doubt Category-Module Pertaining to the module's functionality itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant