Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist koan settings #248

Merged
merged 43 commits into from
Oct 17, 2019
Merged

Persist koan settings #248

merged 43 commits into from
Oct 17, 2019

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Sep 15, 2019 •
edited

PR Summary

Store the module settings as a json file in a user config folder.

Changes

  • Add Get/Set-PSKoanSetting public module commands.
  • Refactor Get/Set-PSKoanLocation to use Get/Set-PSKoanSetting
  • Update tests for Get-PSKoanLocation
  • Update tests for Set-PSKoanLocation
  • Add tests for Get-PSKoanSetting
  • Add tests for Set-PSKoanSetting
  • Add help docs for Get/Set-PSKoanSetting

TODO

  • Add -Default switch to Set-PSKoanSetting to reset back to defaults.
  • Properly implement ShouldProcess support for Set-PSKoanSetting

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Module Pertaining to the module's functionality itself. labels Sep 15, 2019
@vexx32 vexx32 force-pushed the features/Configuration branch 4 times, most recently from 6371a9c to 7ff8fdd Compare September 19, 2019 22:17
@vexx32 vexx32 changed the title Persist koan location with Configuration module Persist koan settings Sep 26, 2019
@vexx32 vexx32 self-assigned this Sep 29, 2019
@vexx32 vexx32 moved this from High priority to In Progress in Module Features / Bugfixes Progress Oct 2, 2019
@vexx32
Copy link
Owner Author

vexx32 commented Oct 14, 2019

Reopen to prod CI.

@vexx32 vexx32 force-pushed the features/Configuration branch 3 times, most recently from b762758 to 9b3fbcd Compare October 14, 2019 01:46
@vexx32
Copy link
Owner Author

vexx32 commented Oct 17, 2019

@indented-automation mind doing a final pass over this if you have a moment, just in case I missed anything obvious? 💖 😊

@indented-automation
Copy link
Contributor

Just the two tiny, tiny comments. Looks good to me otherwise :)

@vexx32 vexx32 merged commit 9bc1a72 into master Oct 17, 2019
Module Features / Bugfixes Progress automation moved this from In Progress to Closed Oct 17, 2019
@vexx32 vexx32 deleted the features/Configuration branch October 17, 2019 16:18
@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indented-automation indented-automation indented-automation left review comments

@steviecoaster steviecoaster Awaiting requested review from steviecoaster

Assignees

@vexx32 vexx32

Labels
Category-Module Pertaining to the module's functionality itself.
Projects
Module Features / Bugfixes Progress
  
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vexx32 @indented-automation