Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds module topic support #251

Merged
merged 20 commits into from
Sep 24, 2019

Conversation

indented-automation
Copy link
Contributor

@indented-automation indented-automation commented Sep 20, 2019

PR Summary

Adds support for elective Modules.

Context

Adds a Module and IncludeModule parameter to allow creation of on-demand content for modules such as ActiveDirectory, and DbaTools.

Changes

  • Moved KoanAttribute to C#. Avoiding such a significant need for using module.
  • Added:
    • Get-PSKoan (merges Get-PSKoanFile and Get-Koan)
    • Get-KoanAst (private)
    • Get-KoanAttribute (private)
    • Test-UnblockedFile (private)
  • Refactored / rebuilt:
    • Get-KoanIt
    • Get-Karma
    • Reset-PSKoan
    • Show-Karma
    • Update-PSKoan
    • Update-PSKoanFile
  • Retired:
    • Get-Koan
    • Get-PSKoanFile
  • Added Format file.
  • Moved argument completers to Register-ArgumentCompleter (see scripts in Init folder).
  • Moved other initialization tasks into individual scripts.
  • Retired Update-TypeData for PSKoans.Results (moved to format file).

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice work! This is quite a bit so I might go over everything a few times in case I miss things. This is the first pass. 💖

PSKoans/Classes/KoanAttribute.ps1 Outdated Show resolved Hide resolved
PSKoans/Init/ModuleConfiguration.ps1 Outdated Show resolved Hide resolved
PSKoans/PSKoans.format.ps1xml Outdated Show resolved Hide resolved
PSKoans/Private/Get-KoanAst.ps1 Outdated Show resolved Hide resolved
PSKoans/Private/Get-KoanAst.ps1 Outdated Show resolved Hide resolved
PSKoans/Public/Get-PSKoan.ps1 Outdated Show resolved Hide resolved
PSKoans/Public/Reset-PSKoan.ps1 Outdated Show resolved Hide resolved
PSKoans/Public/Show-Karma.ps1 Outdated Show resolved Hide resolved
PSKoans/Public/Update-PSKoan.ps1 Outdated Show resolved Hide resolved
PSKoans/Public/Show-Karma.ps1 Show resolved Hide resolved
@vexx32 vexx32 added Category-Module Pertaining to the module's functionality itself. Category-Tests ✅ Pertaining to tests for the module functions. PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. labels Sep 22, 2019
@vexx32 vexx32 added this to Needs triage in Module Features / Bugfixes Progress via automation Sep 22, 2019
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
vexx32
vexx32 previously approved these changes Sep 23, 2019
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fantastic, just wanna update that test description a bit 💖

Tests/Functions/Private/Assert-UnblockedFile.Tests.ps1 Outdated Show resolved Hide resolved
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
vexx32
vexx32 previously approved these changes Sep 23, 2019
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💖 😊

@vexx32 vexx32 moved this from Needs triage to High priority in Module Features / Bugfixes Progress Sep 23, 2019
@indented-automation
Copy link
Contributor Author

Just a short one, updates koan validation tests to account for the module when determining if position is unique.

Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Anything else you need to add before I merge? 💖

@indented-automation
Copy link
Contributor Author

Nope, that's everything I can think of :)

@vexx32 vexx32 merged commit 302263e into vexx32:master Sep 24, 2019
Module Features / Bugfixes Progress automation moved this from High priority to Closed Sep 24, 2019
@vexx32 vexx32 removed the PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Module Pertaining to the module's functionality itself. Category-Tests ✅ Pertaining to tests for the module functions.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants