Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds examples to AboutArrays #257

Merged
merged 10 commits into from
Sep 24, 2019

Conversation

indented-automation
Copy link
Contributor

PR Summary

Updates the AboutArrays topic with new examples.

Fixes #194

Context

Adds a couple of new examples to AboutArrays, showing Count and briefly discussing + and +=.

Changes

  • Adds "arrays are fixed size, elements cannot be added or removed" (not interactive)
  • Adds "new arrays are created using the addition operator" (needs tweaking I think)
  • Adds "the addition operator can be used to join two arrays together"
  • Adds "has properties which describe the size of the array"
  • Adds "creates arrays from a range"
  • Adds "an array of letters may be created from a range"
  • Adds "Object[] and the Array type" (not interactive)

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Some minor stuff to tweak, we can sneak in a few extra assertions as well. 🙂

PSKoans/Koans/Foundations/AboutArrays.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Foundations/AboutArrays.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Foundations/AboutArrays.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Foundations/AboutArrays.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Foundations/AboutArrays.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Foundations/AboutArrays.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Foundations/AboutArrays.Koans.ps1 Outdated Show resolved Hide resolved
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing I missed and then I think this looks great! 😊

PSKoans/Koans/Foundations/AboutArrays.Koans.ps1 Outdated Show resolved Hide resolved
Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
@vexx32 vexx32 merged commit db83193 into vexx32:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AboutArrays Clever Reverse
2 participants