Adds about enumerations koans #263

indented-automation · 2019-09-25T12:11:22Z

PR Summary

Adds the AboutEnumerations topic.

Context

Adds an extensive topic covering just about everything I can think of about enumerations.

Changes

Adds AboutEnumerations topic.

Checklist

Pull Request has a meaningful title.
Summarised changes.
Pull Request is ready to merge & is not WIP.
Added tests / only testable interactively.
- Make sure you add a new test if old tests do not effectively test the code changed.
Added documentation / opened issue to track adding documentation at a later date.

vexx32

Looks good, love the Start-Job workaround. I wonder how it'll be for performance, but we can handle that later if / as needed.

A few bits and pieces I noted as I went through, mostly minor issues or misspellings. 🙂

PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

vexx32

Second pass, basically all just me being picky about phrasing and such 😁

PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

vexx32

Lovely! 😄

Couple minor things I noticed on a reread, and then I think that'll just about do it. 💖 😊

PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

* Creating AboutEnumsAndClasses * Adds AboutEnumerations * Fixes typo * Fixes trailing line * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Review fixes and adds TryParse * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Review fixes * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Review fixes * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Review fixes

indented-automation added 2 commits September 24, 2019 17:37

Creating AboutEnumsAndClasses

73558da

Adds AboutEnumerations

4feb107

indented-automation requested review from steviecoaster and vexx32 as code owners September 25, 2019 12:11

indented-automation added 3 commits September 25, 2019 13:11

Merge branch 'master' into AddsAboutEnumerations

ba0ac82

Fixes typo

b6ccb87

Fixes trailing line

1cb1592

vexx32 added Category-Koans Invoking the Great Doubt PR-Needs-Review 🔍 Let's take a closer look! labels Sep 25, 2019

vexx32 added this to In progress in Koan Topic Tracking via automation Sep 25, 2019

vexx32 requested changes Sep 26, 2019

View reviewed changes

vexx32 added PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. and removed PR-Needs-Review 🔍 Let's take a closer look! labels Sep 26, 2019

indented-automation and others added 17 commits September 26, 2019 08:03

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

64526a3

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

65e68ad

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

5441adf

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

d2e1849

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

2fff36a

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

249cadd

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Merge branch 'master' into AddsAboutEnumerations

901e22f

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

ef9a195

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Review fixes and adds TryParse

6b15bce

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

1fb6166

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

7587a47

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

ad19c16

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

60e53a5

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

db86041

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

598340f

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

9822778

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

361284f

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

indented-automation added 2 commits September 26, 2019 16:15

Review fixes

adb1c13

Merge branch 'master' into AddsAboutEnumerations

f5b1eab

vexx32 requested changes Sep 26, 2019

View reviewed changes

indented-automation and others added 13 commits September 27, 2019 08:04

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

73d6bca

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

9d482ac

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

adbddc9

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

a1c0c83

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

c30b476

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

95f58ef

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

666f6e3

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

b88bf10

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

9dc8aa6

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

5525669

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

f53a23b

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Review fixes

c709a6f

Merge branch 'master' into AddsAboutEnumerations

70dfb37

vexx32 requested changes Sep 27, 2019

View reviewed changes

indented-automation and others added 5 commits September 30, 2019 08:02

Merge branch 'master' into AddsAboutEnumerations

ff6152b

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

dbb0946

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

22abb0d

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutEnumerations.Koans.ps1

55c2219

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Review fixes

fd3a6b1

vexx32 added PR-Needs-Review 🔍 Let's take a closer look! and removed PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. labels Sep 30, 2019

vexx32 approved these changes Oct 1, 2019

View reviewed changes

vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Oct 1, 2019

vexx32 merged commit 09e37fb into vexx32:master Oct 1, 2019

Koan Topic Tracking automation moved this from In progress to Done Oct 1, 2019

indented-automation deleted the AddsAboutEnumerations branch November 1, 2019 16:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds about enumerations koans #263

Adds about enumerations koans #263

indented-automation commented Sep 25, 2019

vexx32 left a comment

vexx32 left a comment

vexx32 left a comment

Adds about enumerations koans #263

Adds about enumerations koans #263

Conversation

indented-automation commented Sep 25, 2019

PR Summary

Context

Changes

Checklist

vexx32 left a comment

Choose a reason for hiding this comment

vexx32 left a comment

Choose a reason for hiding this comment

vexx32 left a comment

Choose a reason for hiding this comment