Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Koan Order for Introduction / Foundations #277

Merged
merged 9 commits into from
Oct 2, 2019
Merged

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Oct 2, 2019

PR Summary

Reorders koans in Introduction to give a better flow from one topic to the next. Topics in Foundations have not been reordered, but their index numbers have been bumped up a bit to have a more linear defined order.

A couple topics needed some edits for clarity or usability, these have been updated as part of this PR.

Changes

  • Move KoanOrder file to repo root
    • Update table format in MD
    • Remove Module column (we can more effectively use headings)
  • Move AboutBooleans to 102
  • Update AboutBooleans.
  • Move AboutNumbers to 103
  • Update AboutNumbers
  • Move AboutStrings to 104
  • Move AboutBinary to 107
  • Move up Foundations koans so their position values look less arbitrary

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

- Reformat table in koan index

- Update note in KoanIndex File

- Remove Module column in favour of using separate tables with headings.

- Move links to bottom of file to neaten table.
- Move AboutBooleans to 102
- Update AboutBooleans.
- Move AboutNumbers to 103
- Update AboutNumbers
- Move AboutStrings to 104
- Move AboutBinary to 107
@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Koans Invoking the Great Doubt Category-Docs 📝 Pertaining to CBH, readme, other documentation labels Oct 2, 2019
@vexx32 vexx32 added this to In progress in Koan Topic Tracking via automation Oct 2, 2019
@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Oct 2, 2019
- Add missing kata to index
- Rename stock challenge to match new kata style
@vexx32 vexx32 merged commit 41ea730 into master Oct 2, 2019
Koan Topic Tracking automation moved this from In progress to Done Oct 2, 2019
@vexx32 vexx32 deleted the Koans/Ordering branch October 2, 2019 16:59
@vexx32 vexx32 mentioned this pull request Oct 2, 2019
1 task
thomasrayner pushed a commit to thomasrayner/PSKoans that referenced this pull request Oct 23, 2019
* 🚧 Move KoanOrder file

* 📝 🎨 Update KoanIndex file

- Reformat table in koan index

- Update note in KoanIndex File

- Remove Module column in favour of using separate tables with headings.

- Move links to bottom of file to neaten table.

* 📝 Update vscode json files

* 📝 Reorder the Introduction segment
- Move AboutBooleans to 102
- Update AboutBooleans.
- Move AboutNumbers to 103
- Update AboutNumbers
- Move AboutStrings to 104
- Move AboutBinary to 107

* 🚧 Update order for Foundations

* 🎨 Add missing newline

* 🎨 Use consistent quoting in AboutBooleans

* 🚧 Fix up katas
- Add missing kata to index
- Rename stock challenge to match new kata style

* 📝 add symbol for incomplete topics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Docs 📝 Pertaining to CBH, readme, other documentation Category-Koans Invoking the Great Doubt
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant