-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Koan Order for Introduction / Foundations #277
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reformat table in koan index - Update note in KoanIndex File - Remove Module column in favour of using separate tables with headings. - Move links to bottom of file to neaten table.
- Move AboutBooleans to 102 - Update AboutBooleans. - Move AboutNumbers to 103 - Update AboutNumbers - Move AboutStrings to 104 - Move AboutBinary to 107
vexx32
added
PR-Needs-Review 🔍
Let's take a closer look!
Category-Koans
Invoking the Great Doubt
Category-Docs 📝
Pertaining to CBH, readme, other documentation
labels
Oct 2, 2019
- Add missing kata to index - Rename stock challenge to match new kata style
thomasrayner
pushed a commit
to thomasrayner/PSKoans
that referenced
this pull request
Oct 23, 2019
* 🚧 Move KoanOrder file * 📝 🎨 Update KoanIndex file - Reformat table in koan index - Update note in KoanIndex File - Remove Module column in favour of using separate tables with headings. - Move links to bottom of file to neaten table. * 📝 Update vscode json files * 📝 Reorder the Introduction segment - Move AboutBooleans to 102 - Update AboutBooleans. - Move AboutNumbers to 103 - Update AboutNumbers - Move AboutStrings to 104 - Move AboutBinary to 107 * 🚧 Update order for Foundations * 🎨 Add missing newline * 🎨 Use consistent quoting in AboutBooleans * 🚧 Fix up katas - Add missing kata to index - Rename stock challenge to match new kata style * 📝 add symbol for incomplete topics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category-Docs 📝
Pertaining to CBH, readme, other documentation
Category-Koans
Invoking the Great Doubt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Reorders koans in
Introduction
to give a better flow from one topic to the next. Topics inFoundations
have not been reordered, but their index numbers have been bumped up a bit to have a more linear defined order.A couple topics needed some edits for clarity or usability, these have been updated as part of this PR.
Changes
Foundations
koans so their position values look less arbitraryChecklist