New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New topic: Regular Expressions #281

Merged

vexx32 merged 10 commits into vexx32:master from thomasrayner:regex-koans

Oct 25, 2019

Contributor

thomasrayner commented Oct 2, 2019

PR Summary

Adds koans for learning regular expressions. This isn't a comprehensive guide, but should be enough to take a beginner from "what the heck is going on?" to "alright this is starting to make sense".

Resolves #280

Context

Regular expressions are as useful as they are intimidating to newcomers - that is very much so. The PSKoans learning platform offers a unique hands-on experience that gets learners trying things out and experimenting for themselves. I believe this is one of the best ways to learn about regex and so this addition may help folks get up to speed quickly.

Changes

Added AboutRegularExpressions

Checklist

Pull Request has a meaningful title.
Summarised changes.
Pull Request is ready to merge & is not WIP.
Added tests / only testable interactively.
- Make sure you add a new test if old tests do not effectively test the code changed.
Added documentation / opened issue to track adding documentation at a later date.

thomasrayner requested review from steviecoaster and vexx32 as code owners

October 2, 2019 21:43

Contributor Author

thomasrayner commented Oct 2, 2019

FYI - this needs a REAL good review. I might have a little bit of tunnel vision on a few of these areas since I modeled this off of a Regex for Complete Noobs session that I've given a couple times. Hopefully the descriptions are descriptive enough, and I'm not missing anything obvious in terms of how koans are supposed to work.

vexx32 requested changes

View reviewed changes

Owner

vexx32 left a comment

First pass! Looks pretty solid, liking what I'm seeing. Gotta refactor a bit here and there, and we can use a few more examples at a few points, but this is a solid start.

Your move. 😉

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

Contributor Author

thomasrayner commented Oct 3, 2019

@vexx32 made changes based on your feedback.

vexx32 added Category-Koans PR-Needs-Review 🔍 labels

vexx32 added this to In progress in Koan Topic Tracking via automation

vexx32 requested changes

View reviewed changes

Owner

vexx32 left a comment •

edited

Looking pretty good! Just some style issues and gotta divide them up a little better, mainly! 💖

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

vexx32 added PR-Awaiting-Author ✏️ and removed PR-Needs-Review 🔍 labels

vexx32 requested changes

View reviewed changes

Owner

vexx32 left a comment

Another round of reviews! \o/

Looking pretty solid so far, love it 💖

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

vexx32 requested changes

View reviewed changes

Owner

vexx32 left a comment

Aaaaand here's the other half of this round 😁

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

thomasrayner force-pushed the regex-koans branch from 2286999 to 869e05c Compare

October 23, 2019 20:01

thomasrayner and others added 8 commits

October 23, 2019 13:04


          wire frame

d471e3f


          added regex koans

5828ca5


          Forgot to link the regex koan

912b7f9


          Changes a/p vexx32 feedback

b25b9ed


          sync changes

03e3c9e


          formatting changes, breaking up some examples into multiple Its

1b064ad


          Apply suggestions from code review

44afd0d

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>


          changes a/p feedback

4908a20

thomasrayner force-pushed the regex-koans branch from 869e05c to 4908a20 Compare

October 23, 2019 20:05


          more explaination, better blanks

5fd3a6b

vexx32 requested changes

View reviewed changes

Owner

vexx32 left a comment

Oops, you broke it!

That aside, this looks pretty awesome! Couple closing comments and then we're good to merge. Thanks so much for putting this together! 💖 😊 🌸

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

vexx32 reviewed

View reviewed changes

Owner

vexx32 left a comment •

edited

Here's some handy dandy suggestions you can sort out, I think this is all we need to sort out before we merge (+ the previous suggestion as well with the missing brace)

I'd do it myself, but you've not got that enabled on this PR so 🤷‍♂ 😁

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved


          backtick begone

74c686c

vexx32 approved these changes

View reviewed changes

vexx32 merged commit defad7f into vexx32:master

Koan Topic Tracking automation moved this from In progress to Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment