🐛 Fix fun advices filenames #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, look at that, I completely missed that. Thanks for this! Can you also open a new issue so I remember we also need to update those commands to throw a more clear error when it can't find a file? The error message is very confusing and doesn't give proper information. 😁 |
vexx32
approved these changes
Oct 11, 2019
5 tasks
vexx32
added
the
Category-Module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I noticed that the cmdlets
Show-Advice -Name Fun*are not working and gives the following error:It's caused by wrong naming (missing
.Advicepart) so I renamed them.Context
No context, just my observation while playing with the tool
Changes
FunWithGUIs.json=>FunWithGUIs.Advice.jsonFunWithCats.json=>FunWithCats.Advice.jsonChecklist