Update-PSKoan - Fix "Yes to All" for ShouldProcess Prompts

[vexx32]

PR Summary

Currently, Update-PSKoan prompts for every file updated, even if the user selects "A" for "Yes to All" at one of the prompts.

Fix is to have the ShouldProcess check only in the iterating function, and allow the child function to use that preference instead of checking each time it is called.

Context

The reason this is needed appears to be that "yes to all" is only respected for the duration of the current function. Since Update-PSKoanFile was being called once for every file that needed updating, the prompt was unable to remember the user's selection from the prior call.

Moving the ShouldProcess test into the parent Update-PSKoan function appears to resolve the issue most neatly.

Changes

• Move $PSCmdlet.ShouldProcess() test from Update-PSKoanFile itself into Update-PSKoan and test before calling the private function.

Checklist

• Pull Request has a meaningful title.
• Summarised changes.
• Pull Request is ready to merge & is not WIP.
• Added tests / only testable interactively.
  • Make sure you add a new test if old tests do not effectively test the code changed.
• Added documentation / opened issue to track adding documentation at a later date.

[vexx32]

@indented-automation mind giving this one a looksee for me? 💖 😊

[indented-automation]

Looks good to me. Good change :)