Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates AboutStrings with new examples #299

Merged
merged 2 commits into from
Oct 23, 2019

Conversation

indented-automation
Copy link
Contributor

PR Summary

Fixes #297

Context

Adds a few new examples to AboutStrings covering expansion of non-existent variables and expansion of variables within a non-existent scope / provider.

Replaces simpler with "more easily" (grammar :)).

Changes

  • Adds 'will expand variables that do not exist'
  • Adds 'can get confused about :'
  • Adds 'can use curly braces to define the variable name in a string with :'
  • 'can be done simpler' to 'can be done more easily'

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 😊 💖

@vexx32 vexx32 added the Category-Koans Invoking the Great Doubt label Oct 23, 2019
@vexx32 vexx32 added this to In progress in Koan Topic Tracking via automation Oct 23, 2019
@vexx32 vexx32 merged commit 508fada into vexx32:master Oct 23, 2019
Koan Topic Tracking automation moved this from In progress to Done Oct 23, 2019
@indented-automation indented-automation deleted the updates-AboutStrings branch November 1, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Koans Invoking the Great Doubt
Projects
Development

Successfully merging this pull request may close these issues.

Update initial koans in AboutStrings
2 participants