Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly Rethrow Get-Karma errors in Show-Karma #302

Merged
merged 5 commits into from
Oct 26, 2019
Merged

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Oct 26, 2019

PR Summary

Before this PR, Show-Karma did not properly catch and rethrow errors from Get-Karma, causing the user to receive errors from Get-Karma and Show-MeditationPrompt when calling Show-Karma, which is unnecessary and confusing.

Context

One error that clearly comes from Show-Karma rather than two errors from the internal functions it's calling is a much better UX.

Changes

  • Properly rethrow Get-Karma errors from Show-Karma.
  • Update Get-Karma error messages to be more useful.

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Module Pertaining to the module's functionality itself. labels Oct 26, 2019
@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Oct 26, 2019
@vexx32 vexx32 merged commit 4f378d2 into master Oct 26, 2019
@vexx32 vexx32 deleted the FixMissingTopicError branch October 26, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Module Pertaining to the module's functionality itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant