Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset-PSKoan: Fixes bug with start position offset #310

Merged
merged 4 commits into from
Oct 28, 2019

Conversation

indented-automation
Copy link
Contributor

PR Summary

Fixes bug with position offset when overwriting koans.

Context

Offset did not account for removed using module statement.

Changes

Replaces using module statements with white space to preserve offset.

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@indented-automation
Copy link
Contributor Author

That was a bit silly, surprised that slipped through testing. At least it now makes sense how the offset could be off.

I've done this as I have to avoid trouble with other using module statements in the future (a nice simple -replace would just make it worse).

Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have been staring at that for days. Thanks for fixing this!! 💖 😊

@vexx32 vexx32 added Category-Module Pertaining to the module's functionality itself. Category-Tests ✅ Pertaining to tests for the module functions. labels Oct 28, 2019
@vexx32 vexx32 added this to In Progress in Module Features / Bugfixes Progress via automation Oct 28, 2019
@vexx32
Copy link
Owner

vexx32 commented Oct 28, 2019

Did a manual test just to make sure, and it looks good! 🎉

Thank you! 😊

@vexx32 vexx32 merged commit 38f8c5e into vexx32:master Oct 28, 2019
Module Features / Bugfixes Progress automation moved this from In Progress to Closed Oct 28, 2019
@indented-automation indented-automation deleted the fixes-reset branch November 1, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Module Pertaining to the module's functionality itself. Category-Tests ✅ Pertaining to tests for the module functions.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants