Fixes bugs in bitwise operations #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indented-automation
requested review from
steviecoaster and
vexx32
as code owners
vexx32
added
Category-Koans
vexx32
approved these changes
Jan 22, 2020
Comment on lines
+217
to
+226
| This can make the result of the operation below confusing. When written in binary, the result is | ||
| similar to: | ||
|
|
||
| 11111111 11111111 11111111 ________ | ||
|
|
||
| -band can be used to mask the result, limiting the possible result to a single byte. | ||
|
|
||
| 11111111 11111111 11111111 ________ | ||
| -band 00000000 00000000 00000000 11111111 | ||
| #> |
There was a problem hiding this comment.
This mismatched indentation looks a bit funny 😁
Also, wow that's confusing as all hell. Even with a specific byte-type input it still upcasts to int32... I'm sure that's probably a .NET thing, but... damn.
|
@JoeWatts would you like to give the changes a quick once-over as well since you've run through these pretty recently? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #349
Context
Bug fixes for bitwise operators. Can't beat tech review, thanks!
Changes
Checklist