Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement simple current topic information cache #355

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Implement simple current topic information cache #355

merged 2 commits into from
Jan 30, 2020

Commits on Jan 29, 2020

  1. ✨ Add topic data caching for -Meditate 

    Adds functionality to store topic completion data to a module-scope var
with Get-Karma.
This simple cache will then be pulled and subsequently cleared by
Show-Karma when used with -Contemplate.

If there is no cached data, Show-Karma will call Get-Karma.

The cache allows us to avoid double-calling Get-Karma when, for example,
the user calls Show-Karma to view results and then follows with
Show-Karma -Contemplate to open the file.
    @vexx32
    vexx32 committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    a7437a9 View commit details
    Browse the repository at this point in the history

  2. ✅ Update tests 

    - Update Get-Karma tests to ensure variable is set
- Update Show-Karma tests to ensure variable
is properly used and subsequently cleared.
    @vexx32
    vexx32 committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    3b7b5f0 View commit details
    Browse the repository at this point in the history