Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a comment with further explanation for rounding #357

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Added a comment with further explanation for rounding #357

merged 2 commits into from
Feb 4, 2020

Conversation

jschpp
Copy link
Sponsor Contributor

@jschpp jschpp commented Feb 3, 2020

PR Summary

Added comment to further detail rounding in Powershell.

Resolves #352

Context

See #352

Changes

  • Added comment

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added Category-Koans Invoking the Great Doubt PR-Needs-Review 🔍 Let's take a closer look! labels Feb 3, 2020
vexx32
vexx32 requested changes Feb 3, 2020
View reviewed changes
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks a lot clearer, thank you! 😊

I have some small suggestions on the specific wording but that's mostly me being picky as all heck 😁

PSKoans/Koans/Introduction/AboutNumbers.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Introduction/AboutNumbers.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Introduction/AboutNumbers.Koans.ps1 Outdated Show resolved Hide resolved
@jschpp jschpp requested a review from vexx32 February 4, 2020 10:21
@vexx32 vexx32 merged commit a68479b into vexx32:master Feb 4, 2020
@vexx32
Copy link
Owner

vexx32 commented Feb 4, 2020 •
edited
Loading

Thanks for your contribution @jschpp! 💖 😊

@jschpp jschpp deleted the fix-352 branch February 5, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vexx32 vexx32 vexx32 approved these changes

@steviecoaster steviecoaster Awaiting requested review from steviecoaster

Assignees
No one assigned
Labels
Category-Koans Invoking the Great Doubt PR-Needs-Review 🔍 Let's take a closer look!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more explanation for banker's rounding in AboutNumbers
2 participants
@jschpp @vexx32